Skip to content

Fix Typo in Http Client #13991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1,941 commits into from
Closed

Conversation

debreczeniandras
Copy link

interopable => interoperable

javiereguiluz and others added 30 commits June 1, 2020 09:07
* 5.0:
  Update custom_normalizer.rst
* 4.4:
  Update events.rst
* 5.0:
  Update events.rst
* 4.4:
  Update reactjs.rst
* 5.0:
  Update reactjs.rst
…Time (Arioch171)

This PR was merged into the 5.1 branch.

Discussion
----------

Update http_foundation.rst to replace withExpiresTime

The method withExpiresTime does not exist in class https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpFoundation/Cookie.php#L146.
I think it should be withExpires instead.

Commits
-------

af77e76 Fix withExpiresTime replaced by withExpires
* 4.4:
  Update releases.rst
* 5.0:
  Update releases.rst
* 4.4:
  Fix: message must be notInRangeMessage
* 5.0:
  Fix: message must be notInRangeMessage
* 4.4:
  Update installation.rst
* 5.0:
  Update installation.rst
…ates automatically (javiereguiluz)

This PR was merged into the 5.1 branch.

Discussion
----------

[DI] Mention that container.no_preload tag propagates automatically

Fixes symfony#13583.

Commits
-------

062497a [DI] Mention that container.no_preload tag propagates automatically
…ax constraint (javiereguiluz)

This PR was submitted for the master branch but it was squashed and merged into the 5.1 branch instead.

Discussion
----------

[Validator] Documented the ExpressionLanguageSyntax constraint

@Andrej-in-ua could you please review this proposal to document the `ExpressionLanguageSyntax` constraint that you created? Thanks!

@xabbuh @weaverryan @wouterj while documenting this, I wondered if `names` and `validatedNames` options are overlapping a bit. Maybe we can merge them in a single option as follows?

```php
<?php
// Before

/**
 * @Assert\ExpressionLanguageSyntax(
 *     names = ['user', 'shipping_centers'],
 *     validateNames = true
 * )
 */
protected $shippingOptions;

// After

/**
 * @Assert\ExpressionLanguageSyntax(
 *     allowedVariables = ['user', 'shipping_centers']
 * )
 */
protected $shippingOptions;
```

Commits
-------

0984459 [Validator] Documented the ExpressionLanguageSyntax constraint
…s (weaverryan)

This PR was squashed before being merged into the 5.0 branch.

Discussion
----------

Adding details about Encore dev-server and https

Hi!

See: https://github.com/symfony/cli/issues/93

Just some missing docs on use the `dev-server` with the Symfony binary.

Commits
-------

828eb9b Adding details about Encore dev-server and https
* 5.0:
  Adding details about Encore dev-server and https
This PR was submitted for the 5.1 branch but it was merged into the 5.0 branch instead.

Discussion
----------

Update releases.rst

Bump up the version numbers

Commits
-------

68f1821 Bump versions of releases
* 5.0:
  Bump versions of releases
* 4.4:
  Update information in flex about added files for twig
* 5.0:
  Update information in flex about added files for twig
…ased Security system (wouterj)

This PR was squashed before being merged into the 5.1 branch.

Discussion
----------

[Security] Added docs about the authenticator-based Security system

As the new system is experimental, I think it's best to not update the main documentation of Security yet (also, the main guide isn't really affected by the new system - except from the removal of anonymous). This can be done once we deprecate the old system (in 5.3 or 5.4).

I do however think we should link more to this article, as I want to push people to use it. What do you think about adding a `.. tip::` in:

* [x] `security/guard_authentication` & `security/form_login_setup`
* [ ] <s>`security/custom_authentication_provider` (replace the one to Guard)</s>
* [x] `security` (at the start, as a "hey, please start by doing `enable_authenticator_manager: true`")

Fixes symfony#13575

Commits
-------

bdb5271 [Security] Added docs about the authenticator-based Security system
…capile)

This PR was squashed before being merged into the 5.1 branch.

Discussion
----------

[Security] anonymous: lazy deprecation warning

After upgrade to symfony/security-bundle to 5.1 and I got the deprecation warning Since symfony/security-bundle 5.1: Using "anonymous: lazy" to make the firewall lazy is deprecated, use "anonymous: true" and "lazy: true" instead.
symfony#13749

Commits
-------

73d1789 [Security] anonymous: lazy deprecation warning
javiereguiluz and others added 25 commits July 8, 2020 17:14
* 5.0:
  Added some links
  Remove links to not existing channel pages
* '5.1' of github.com:symfony/symfony-docs:
  [symfony#13919] Use ContainerConfigurator and fixes some bugs after testing the example code
  Fixed micro kernel demo
* 4.4:
  [PropertyInfo] Update property_info.rst
* 5.0:
  [PropertyInfo] Update property_info.rst
* 4.4:
  Improve profiler
* 5.0:
  Improve profiler
Fix the link for `PreAuthenticatedUserBadge` class
* 4.4:
  Tweak security checker wording
* 5.0:
  Tweak security checker wording
This PR was merged into the 5.1 branch.

Discussion
----------

Update experimental_authenticators.rst

Fix the link for `PreAuthenticatedUserBadge` class

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/releases for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

486a1fe Update experimental_authenticators.rst
* 4.4:
  Add missing path in PHP routing configuration example
* 5.0:
  Add missing path in PHP routing configuration example
* 4.4:
  Corrected grammar to increased readability.
* 5.0:
  Corrected grammar to increased readability.
* 4.4:
  Updated some config file paths
  Use "closure-style" PHP configuration format in code examples
  [Security] Mention the feature to use a custom AccessDecisionManager
  Update bundles.rst
  [Console] Update input.rst
* 5.0:
  Updated some config file paths
  Use "closure-style" PHP configuration format in code examples
  [Security] Mention the feature to use a custom AccessDecisionManager
  Update bundles.rst
  [Console] Update input.rst
…verryan)

This PR was merged into the 5.0 branch.

Discussion
----------

default path of migrations changed in recipe

See symfony/recipes#797

Obviously, we can't really know what path the user will have configured. All we can do is have it match the latest config.

Btw, I chose 5.0 as the base branch... but I'm open to other suggestions.

Cheers!

Commits
-------

3be2860 default path of migrations changed in recipe
* 5.0:
  default path of migrations changed in recipe
Hello,

I removed the `Migrations` folder from exclude.
Since 5.1, this directory has been moved outside of `src`.
This PR was submitted for the 5.1 branch but it was merged into the 5.0 branch instead.

Discussion
----------

Update service_container.rst

Hello,

I removed the `Migrations` folder from exclude.
Since 5.1, this directory has been moved outside of `src`.

Commits
-------

fe2ad65 Update service_container.rst
* 5.0:
  Update service_container.rst
@debreczeniandras
Copy link
Author

closed in favour of: #13992
Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.